core/rawdb: integrate eradb backend for RPC #31604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
changed the title
| @@ -237,7 +237,7 @@ func initGenesis(ctx *cli.Context) error { | |||
| overrides.OverrideVerkle = &v | |||
| } | |||
|
|
|||
| chaindb, err := stack.OpenDatabaseWithFreezer("chaindata", 0, 0, ctx.String(utils.AncientFlag.Name), "", false) | |||
| chaindb, err := stack.OpenDatabaseWithFreezer("chaindata", 0, 0, ctx.String(utils.AncientFlag.Name), "", false, "") | |||
There was a problem hiding this comment.
We should probably make this a config struct
|
Twist the era path resolution a bit:
|
| return f.eradb.GetRawReceipts(number) | ||
| } | ||
| return nil, errUnknownTable | ||
| } |
There was a problem hiding this comment.
TODO (sina and gary)
We should support AncientRange as well
There was a problem hiding this comment.
Created a ticket for it for a future PR
rjl493456442
previously approved these changes
Apr 18, 2025
It's best to avoid callbacks, especially in the locked variant of the LRU, since it can lead to weird bugs.
This changes the file cache to avoid some issues around file closing. With the new logic, a file will never be closed while it is still in use on any goroutine accessing the era store. To do this, we maintain a reference counter for each file. The new cache also explicitly tracks files which are being opened. This ensures that 'replacing' a file in the cache cannot happen.
s1na
commented
May 14, 2025
| } | ||
|
|
||
| // Add3 adds a value to the cache. If an item was evicted to store the new one, it returns the evicted item. | ||
| func (c *BasicLRU[K, V]) Add3(key K, value V) (ek K, ev V, evicted bool) { |
There was a problem hiding this comment.
Can we at least use Add2 for name? :))
This removes the use of atomic reference counters in favor of using a scheme where all changes to reference counters are done while holding the Store mutex. Store.Close now synchronizes with all running accesses and waits until all files have been closed before returning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #31279